Fix test assertions#777
Merged
Merged
Conversation
simplified some assertions. opted to use assertThat in places where matchers exist.
littleaj
commented
Nov 29, 2018
| public final class EnterExitClassVisitorTest { | ||
|
|
||
| // TODO fix these tests | ||
| // @Ignore |
Contributor
Author
There was a problem hiding this comment.
I made an attempt to fix this test, but it was a time sink. Instead, I added a TODO comment for later.
littleaj
commented
Nov 29, 2018
| try { | ||
| value += Double.parseDouble(String.valueOf(obj)); | ||
| } catch (Exception e) { | ||
| assertFalse(true); |
Contributor
Author
There was a problem hiding this comment.
Please, do not do this...use Assert.fail if you intend to fail the test when it reaches this line.
Contributor
|
Thanks @littleaj. This was indeed needed. |
dhaval24
approved these changes
Dec 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #440.
Addresses the
assertEqualsparameters which were reversed. Also, there are some other test improvements.