Added example for adding a JMX Counter for garbage collection time#750
Merged
dhaval24 merged 1 commit intoSep 28, 2018
Merged
Conversation
Contributor
|
Thanks for this, @mjknowles! We'll take a look and get this merged. We're always looking for ways to improve our documentation and onboarding process. |
dhaval24
approved these changes
Sep 28, 2018
dhaval24
left a comment
Contributor
There was a problem hiding this comment.
@mjknowles this looks great! Even, I was puzzled with this for a while. Thank you very much for contributing to our documentation and improving it. We really really appreciate it! Looking forward to even more contributions in future :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submitting this PR for consideration of modifying the JMX Counter examples in the spring-boot-starter README. Maybe this is obvious to others, but I had to spend time figuring out how to add a garbage collector counter with a comma in the ObjectName. Perhaps this can save someone time in the future.