fixing the http dependency collection issue with NetFlix Zuul#680
Merged
Conversation
littleaj
suggested changes
Jun 8, 2018
littleaj
left a comment
Contributor
There was a problem hiding this comment.
Overall, this looks good. See my comment about context properties.
| telemetry.setId(correlationId); | ||
| telemetry.setResultCode(Integer.toString(result)); | ||
| telemetry.setType("HTTP"); | ||
| telemetry.getContext().getProperties().put("URI", uri); |
Contributor
littleaj
approved these changes
Jun 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #676
This PR fixes the HTTP dependency collection issue encountered with Netflix Zuul library.
It moves the logic of getting the Path and the Target into CoreAgentNotificationHandler instead of byte code instrumentation
We now again instrument the getRequestLine() method of HttpRequest interface instead of relying on HttpUriRequest which is not always true in all the cases.
For significant contributions please make sure you have completed the following items: