Skip to content

Check connection string env var before loading from a file#3794

Merged
heyams merged 5 commits into
mainfrom
heya/revert-connection-string
Jul 24, 2024
Merged

Check connection string env var before loading from a file#3794
heyams merged 5 commits into
mainfrom
heya/revert-connection-string

Conversation

@heyams

@heyams heyams commented Jul 23, 2024

Copy link
Copy Markdown
Contributor

Fix #3707

replaced #3759

regression from #3471

@heyams heyams changed the title Revert connection string config Check connection string env var before loading from a file Jul 23, 2024

@trask trask left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were going to revert the change you made in #3471?

@heyams

heyams commented Jul 23, 2024

Copy link
Copy Markdown
Contributor Author

I thought we were going to revert the change you made in #3471?

you cannot simply revert because we support loading from the file feature.

@heyams heyams merged commit 4e231e5 into main Jul 24, 2024
@heyams heyams deleted the heya/revert-connection-string branch July 24, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

APPLICATIONINSIGHTS_CONNECTION_STRING does not work in 3.5.x, works in 3.4.x

3 participants