Conversation
trask
reviewed
Oct 25, 2023
trask
reviewed
Oct 25, 2023
trask
approved these changes
Oct 25, 2023
| featureList.add(Feature.PREVIEW_DISK_PERSISTENCE_MAX_SIZE_MB); | ||
| } | ||
| if (!config.preview.useNormalizedValueForNonNormalizedCpuPercentage) { | ||
| featureList.add(Feature.PREVIEW_DONT_USE_NORMALIZED); |
Member
There was a problem hiding this comment.
sorry, I think I was too brief on my prior comment, we should probably make this a bit clearer (longer 😅), but can do that later
Contributor
Author
There was a problem hiding this comment.
it's just a way to identify the preview feature. do you prefer PREVIEW_DONT_USE_NORMALIZED_VALUE_FOR_NON_NORMALIZED_CPU_PERCENTAGE because of the negation?
this is even longer
Member
There was a problem hiding this comment.
ya, it's the negation that I was commenting on
maybe PREVIEW_REPORT_NON_NORMALIZED_CPU_PERCENTAGE
since essentially this setting opts in to (correctly) reporting the non-normalized cpu percentage (we're only not enabling it by default yet due to it being a breaking change)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.