Skip to content

Enable sampling override using thread.name#3285

Merged
heyams merged 11 commits into
mainfrom
heya/add-thread-attributes-to-sampler
Sep 18, 2023
Merged

Enable sampling override using thread.name#3285
heyams merged 11 commits into
mainfrom
heya/add-thread-attributes-to-sampler

Conversation

@heyams

@heyams heyams commented Sep 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

fix #3145

@heyams heyams force-pushed the heya/add-thread-attributes-to-sampler branch from ff59495 to c7e4088 Compare September 13, 2023 21:36
trask
trask reviewed Sep 15, 2023
View reviewed changes
Comment thread ...c/main/java/com/microsoft/applicationinsights/agent/internal/sampling/SamplingOverrides.java Outdated
Comment thread ...c/main/java/com/microsoft/applicationinsights/agent/internal/sampling/SamplingOverrides.java Outdated
Comment thread ...c/main/java/com/microsoft/applicationinsights/agent/internal/sampling/SamplingOverrides.java Outdated
Comment thread ...c/main/java/com/microsoft/applicationinsights/agent/internal/sampling/SamplingOverrides.java Outdated
Comment thread ...s/apps/SamplingOverrides/src/smokeTest/resources/applicationinsights-thread-id-and-name.json Outdated
Comment thread ...s/apps/SamplingOverrides/src/smokeTest/resources/applicationinsights-thread-id-and-name.json
@trask

trask commented Sep 15, 2023

Copy link
Copy Markdown
Member

@heyams I just realized thread.id is an AttributeKey<Long>. I believe we only support String and List<String> attribute types in sampling overries. Probably we can just remove thread.id support from this PR. I don't imagine that would be something someone would want to sample based on anyways.

@heyams heyams enabled auto-merge (squash) September 18, 2023 19:26
@heyams heyams merged commit 9235244 into main Sep 18, 2023
@heyams heyams deleted the heya/add-thread-attributes-to-sampler branch September 18, 2023 19:40
@trask trask changed the title Enable sampling override using thread.id and thread.name Enable sampling override using thread.name Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trask trask trask approved these changes

@ramthi ramthi Awaiting requested review from ramthi ramthi is a code owner

+1 more reviewer

@jeanbisutti jeanbisutti jeanbisutti left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Is there a way to sample inProc dependency?

3 participants

@heyams @trask @jeanbisutti