Skip to content

Warn on internal attribute usage#2314

Merged
trask merged 2 commits into
mainfrom
warn-on-internal-attribute-usage
Jun 2, 2022
Merged

Warn on internal attribute usage#2314
trask merged 2 commits into
mainfrom
warn-on-internal-attribute-usage

Conversation

@trask

@trask trask commented Jun 1, 2022

Copy link
Copy Markdown
Member

No description provided.

@trask trask marked this pull request as ready for review June 1, 2022 23:22
@trask trask requested a review from heyams as a code owner June 1, 2022 23:22
}
}

private static void logWarningIfUsingInternalAttributes(Configuration.ProcessorAction action) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not reusable, i think it's ok to be inline. it's confusing to have so many overloading methods.

@trask trask merged commit 059ff32 into main Jun 2, 2022
@trask trask deleted the warn-on-internal-attribute-usage branch June 2, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants