Skip to content

Fix URI parse error#2067

Merged
trask merged 3 commits into
mainfrom
fix-parse-error
Jan 24, 2022
Merged

Fix URI parse error#2067
trask merged 3 commits into
mainfrom
fix-parse-error

Conversation

@trask

@trask trask commented Jan 22, 2022

Copy link
Copy Markdown
Member

Fixes this error

WARN c.m.a.a.internal.exporter.Exporter - Parsing http.url: Illegal character in query at index 167: REDACTED
at java.net.URI$Parser.fail(URI.java:2845)
at java.net.URI$Parser.checkChars(URI.java:3018)
at java.net.URI$Parser.parseHierarchical(URI.java:3108)
at java.net.URI$Parser.parse(URI.java:3050)
at java.net.URI.<init>(URI.java:588)
at com.microsoft.applicationinsights.agent.internal.exporter.Exporter.getTargetForHttpClientSpan(Exporter.java:546)
at com.microsoft.applicationinsights.agent.internal.exporter.Exporter.applyHttpClientSpan(Exporter.java:479)
at com.microsoft.applicationinsights.agent.internal.exporter.Exporter.applySemanticConventions(Exporter.java:324)
at com.microsoft.applicationinsights.agent.internal.exporter.Exporter.exportRemoteDependency(Exporter.java:272)
at com.microsoft.applicationinsights.agent.internal.exporter.Exporter.internalExport(Exporter.java:221)
at com.microsoft.applicationinsights.agent.internal.exporter.Exporter.export(Exporter.java:177)
at io.opentelemetry.sdk.trace.export.BatchSpanProcessor$Worker.exportCurrentBatch(BatchSpanProcessor.java:305)
at io.opentelemetry.sdk.trace.export.BatchSpanProcessor$Worker.run(BatchSpanProcessor.java:222)
at java.lang.Thread.run(Thread.java:748)

@trask trask requested review from heyams and kryalama as code owners January 22, 2022 00:57
heyams
heyams reviewed Jan 24, 2022
View reviewed changes
Comment thread ...test/java/com/microsoft/applicationinsights/agent/internal/exporter/UrlParserTargetTest.java

import org.junit.jupiter.api.Test;

public class UrlParserTargetTest {

@heyams heyams Jan 24, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need both urlparserapthtest and urlparsertargettest.java?

we can just update urlparsertest.java?

@trask trask Jan 24, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that file was getting really long, i thought it helped to break it out into two separate tests

@heyams heyams Jan 24, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see

@trask trask merged commit 19713f1 into main Jan 24, 2022
@trask trask deleted the fix-parse-error branch January 24, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@heyams heyams heyams approved these changes

@kryalama kryalama kryalama approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trask @heyams @kryalama