lazily set website site name#1536
Merged
Merged
Conversation
trask
reviewed
Mar 5, 2021
trask
left a comment
Member
There was a problem hiding this comment.
Instead of having separate AiConnectionString and AiWebsiteSiteName classes (and more in the future), how about a single LazyConfiguration class, and then we can move all the logic of reading the env vars into the AI code, and won't need to modify the otel-fork in the future when we add support for other lazy env vars?
trask
reviewed
Mar 10, 2021
trask
approved these changes
Mar 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.