Fix sampling rate recorded for dependencies#1477
Closed
trask wants to merge 2 commits into
Closed
Conversation
heyams
reviewed
Feb 9, 2021
heyams
reviewed
Feb 10, 2021
| return telemetryClient; | ||
| } | ||
|
|
||
| public static double getSamplingPercentage() { |
Contributor
There was a problem hiding this comment.
I still think sampling rate inside TraceState is a bit awkward since you will need to strip it out before sending out the payload. Can we keep it in Global? AiSampler can access Global, but then you may need to setDelegate inside AiSampler again. Can we chat offline about this?
Member
Author
|
Closing, will open a fresh PR for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.