Skip to content

Resolve NullPointer exception when running under test with MockMvc#1293

Merged
littleaj merged 2 commits into
microsoft:masterfrom
andrejpk:andrejpk/mockmvc-error
Aug 12, 2020
Merged

Resolve NullPointer exception when running under test with MockMvc#1293
littleaj merged 2 commits into
microsoft:masterfrom
andrejpk:andrejpk/mockmvc-error

Conversation

@andrejpk

Copy link
Copy Markdown
Contributor

Fix #1281 by adding a simple null check in WebRquestTrackingFilter

If needed, here's a line for CHANGELOG.md (I don't know what version to tag it under. I'm happy to add this to my PR if I know where to put it):

  • Fixed NullPointer when testing with MockMvc (#)

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed (n/a)
  • CHANGELOG.md updated (see note above)

@littleaj littleaj self-requested a review July 30, 2020 17:48
@littleaj

Copy link
Copy Markdown
Contributor

@andrejpk , Thanks for this! You can make a new section at the top of CHANGELOG.md for 2.6.2-BETA.3. We'll update it later if needed.

@andrejpk

Copy link
Copy Markdown
Contributor Author

Thanks, @littleaj , added.

@littleaj

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@littleaj littleaj merged commit 9705fc8 into microsoft:master Aug 12, 2020
@andrejpk andrejpk deleted the andrejpk/mockmvc-error branch August 14, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MockMvc-based tests fail with App Insights enabled

2 participants