add asserts to verify response code.#1011
Merged
Merged
Conversation
Contributor
Author
|
latest commit should fix #600 (pending review) |
if an exception has been thrown, assume failed request with status=500
c858563 to
d3821f1
Compare
trask
reviewed
Aug 10, 2019
| @@ -112,6 +114,11 @@ public void handleEnd(ServletRequest request, ServletResponse response, | |||
| int resultCode = extractor.getStatusCode(response); | |||
| requestTelemetry.setSuccess(resultCode < 400); | |||
| requestTelemetry.setResponseCode(Integer.toString(resultCode)); | |||
Member
There was a problem hiding this comment.
I think these three lines above can go in a conditional ... == null and then the if below can be else
trask
approved these changes
Aug 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should Fix #810