Fix registration of custom JMX performance counters#1042
Merged
Conversation
This was not broken, but seems better to change this as well, at least for consistency, given the issue with Jmx configuration after migrating from JAXB's XmlElementWrapper. This covers all places that used to use JAXB's XmlElementWrapper before migration to XStream.
3ecdd72 to
3db51de
Compare
littleaj
approved these changes
Aug 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registration of custom JMX performance counters was failing with error:
Failed to register JMX performance counters: 'java.lang.ClassCastException: com.microsoft.applicationinsights.internal.config.WindowsPerformanceCounterXmlElement cannot be cast to com.microsoft.applicationinsights.internal.config.JmxXmlElement'