[Main][Task] 27922617: Provide Custom Provider Under Web Worker for Offline Channel #2649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for custom storage providers in the Offline Channel, allowing developers to provide their own storage implementations for web worker environments. This enables more flexible storage solutions beyond the built-in LocalStorage, SessionStorage, and IndexedDB providers.
Key changes:
- Added
customProviderandcustomUnloadProviderconfiguration options to allow custom storage implementations - Enhanced provider initialization logic to prioritize custom providers over default ones
- Added comprehensive test coverage for custom provider scenarios
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| channels/offline-channel-js/src/OfflineBatchHandler.ts | Added custom provider initialization logic and fallback handling for unload scenarios |
| channels/offline-channel-js/src/Interfaces/IOfflineProvider.ts | Added interface definitions for customProvider and customUnloadProvider configuration options |
| channels/offline-channel-js/Tests/Unit/src/offlinechannel.tests.ts | Added import and registration for new custom provider tests |
| channels/offline-channel-js/Tests/Unit/src/customprovider.tests.ts | Added comprehensive test suite covering custom provider initialization, fallback scenarios, and storage operations |
Comments suppressed due to low confidence (1)
channels/offline-channel-js/Tests/Unit/src/customprovider.tests.ts:1
- The MockNoopProvider is missing the addEvent method implementation in the dynamicProto constructor. This method should be included to match the interface requirements.
import { AITestClass, Assert } from "@microsoft/ai-test-framework";
channels/offline-channel-js/Tests/Unit/src/offlinechannel.tests.ts
Outdated
Show resolved
Hide resolved
channels/offline-channel-js/Tests/Unit/src/customprovider.tests.ts
Outdated
Show resolved
Hide resolved
rads-1996
reviewed
Sep 22, 2025
| return provider; | ||
| } | ||
| } catch (e) { | ||
| // eslint-disable-next-line no-empty |
Member
There was a problem hiding this comment.
if we dont pass anything here then what is returned in _unloadProvider when an exception is thrown here? Will this be a type mismatch or will it pass an empty string?
MSNev
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.