-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
tests: various improvements for Octoprobe (WIP) #17782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dpgeorge
wants to merge
22
commits into
micropython:master
Choose a base branch
from
dpgeorge:tests-improvements-for-octoprobe
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
tests: various improvements for Octoprobe (WIP) #17782
dpgeorge
wants to merge
22
commits into
micropython:master
from
dpgeorge:tests-improvements-for-octoprobe
+205
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17782 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 171 171
Lines 22298 22299 +1
=======================================
+ Hits 21937 21938 +1
Misses 361 361 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
18ad8c0 to
5958518
Compare
|
Code size report: |
c399b93 to
ca374fa
Compare
Contributor
|
@dpgeorge: Two easy to reproduce bugs which could be added to ths PR |
aee37bb to
8920560
Compare
66db214 to
3993063
Compare
ec94811 to
f7dc897
Compare
941611d to
4d60e1c
Compare
96642d5 to
87300a8
Compare
This was referenced Aug 26, 2025
87300a8 to
35f3163
Compare
35f3163 to
a82b761
Compare
This was referenced Sep 23, 2025
011aa7c to
64c8c24
Compare
This was referenced Oct 7, 2025
62f5dcf to
39ba8fe
Compare
39ba8fe to
e143b45
Compare
Signed-off-by: Damien George <damien@micropython.org>
Some boards define ESP32C3, some define ESP32-C3. Probably it should just use default pins, eg SPI(1). Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Eg for ESP8266-512K. Signed-off-by: Damien George <damien@micropython.org>
In --via-mpy --emit native mode. Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Tested on ADAFRUIT_ITSYBITSY_M0_EXPRESS. Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
On bare-metal lwIP targets, there's only enough buffer space for 4 groups. Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
The test runner will abort with error code 2 if: - the target could not be detected (enter_raw_repl failed at the detection stage) - unittest is not installed but is needed Signed-off-by: Damien George <damien@micropython.org>
Now, if a test fails and crashes a board to the point it no longer responds
(but the serial connection is still alive and able to read/write), it only
takes a maximum of 30 + 5 * 4 = 50 seconds to detect that state and exit
the test run (previously it would be 30 + 10 seconds * number of remaining
tests = potentially large).
Can test this by adding the following to a test:
import time, micropython
micropython.kbd_intr(-1)
while 1:
time.sleep(1)
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
To reduce heap memory use. Signed-off-by: Damien George <damien@micropython.org>
Not sure if this is actually better, may lead to more fragmentation. Probably needs some tests. See micropython#4087 Really need to retry alloc with smaller amount if it fails, but then really we need a lazy malloc, per the TODO in py/misc.h. Signed-off-by: Damien George <damien@micropython.org>
They don't have the `freq` argument. Signed-off-by: Damien George <damien@micropython.org>
So it can be properly skipped. Signed-off-by: Damien George <damien@micropython.org>
e143b45 to
fa51543
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a collection of various small improvements to the test suite to get Octoprobe to pass more of the tests.
Once fully working, these changes will be made into separate PRs.
Testing
To be tested by Octoprobe: https://reports.octoprobe.org/
Test report prior to this PR: https://reports.octoprobe.org/github_selfhosted_testrun_194/octoprobe_summary_report.html
Test report with this PR: https://reports.octoprobe.org/github_selfhosted_testrun_199/octoprobe_summary_report.html