Skip to content

mpremote/mp_errno: Fix errno.ENOTBLK error on Windows. #17775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dpgeorge merged 1 commit into from
Aug 1, 2025
Merged

mpremote/mp_errno: Fix errno.ENOTBLK error on Windows. #17775

dpgeorge merged 1 commit into from
Aug 1, 2025

Conversation

@Josverl
Copy link
Contributor

@Josverl Josverl commented Jul 28, 2025 •
edited
Loading

Summary

not all errors defined in stdlib errno are available on Windows.
Specifically errno.ENOTBLK is not.
Not 100% sure about availability of all other codes across platforms either, so would be good if someone can confirm that MacOS has no problems either.

This was not caught in CI, as there is no CI , nor tests for mpremote on Windows.

closes: #17773

Testing

Manual testing on Windows 11 and WSL2.

@github-actions
Copy link

github-actions bot commented Jul 28, 2025

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

@Josverl Josverl mentioned this pull request Jul 28, 2025
Merged
@Josverl
Copy link
Contributor Author

Josverl commented Jul 28, 2025 •
edited
Loading

IMO its quite unlikely that the failing test (thread/thread_gc1.py) is caused by this PR.
it has been reported as a flaky test in other PRs as well.

@codecov
Copy link

codecov bot commented Jul 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.38%. Comparing base (062e82a) to head (7007088).
⚠️ Report is 32 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #17775   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         171      171           
  Lines       22240    22240           
=======================================
  Hits        21881    21881           
  Misses        359      359

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dpgeorge dpgeorge added the tools Relates to tools/ directory in source, or other tooling label Aug 1, 2025
dpgeorge
dpgeorge approved these changes Aug 1, 2025
View reviewed changes
Copy link
Member

@dpgeorge dpgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, this looks fine.

I confirmed that errno.ENOTBLK exists on macOS on Python 3.8.9.

@Josverl @dpgeorge
tools/mpremote: Fix errno.ENOTBLK attribute error on Windows.
4ba626a 
Not all errors defined in stdlib errno are available on Windows.
Specifically, errno.ENOTBLK is not.

Fixes issue micropython#17773.

Signed-off-by: Jos Verlinde <Jos_Verlinde@hotmail.com>
@dpgeorge dpgeorge force-pushed the mpr/errno_on_windows branch from 7007088 to 4ba626a Compare August 1, 2025 04:54
@dpgeorge dpgeorge merged commit 4ba626a into micropython:master Aug 1, 2025
68 of 69 checks passed
@Josverl Josverl deleted the mpr/errno_on_windows branch August 1, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpgeorge dpgeorge dpgeorge approved these changes

Assignees

No one assigned

Labels

tools Relates to tools/ directory in source, or other tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

mpremote: Unknown errno.ENOTBLK on Windows

2 participants

@Josverl @dpgeorge