Skip to content

ports/unix: Enable mbedtls cert time validation. #13099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dpgeorge merged 2 commits into from
Dec 1, 2023
Merged

ports/unix: Enable mbedtls cert time validation. #13099

dpgeorge merged 2 commits into from
Dec 1, 2023

Conversation

@Carglglz
Copy link
Contributor

@Carglglz Carglglz commented Nov 30, 2023

No description provided.

@codecov
Copy link

codecov bot commented Nov 30, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad806df) 98.36% compared to head (436a7c6) 98.36%.

❗ Current head 436a7c6 differs from pull request most recent head b5449b0. Consider uploading reports for the commit b5449b0 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #13099   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         159      159           
  Lines       20978    20978           
=======================================
  Hits        20636    20636           
  Misses        342      342

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Nov 30, 2023
Merged
Closed
@dpgeorge dpgeorge added this to the release-1.22.0 milestone Dec 1, 2023
Carglglz and others added 2 commits December 1, 2023 15:08
@Carglglz @dpgeorge
unix/mbedtls: Enable mbedtls cert time validation.
20ffbe1 
To match other ports.

Signed-off-by: Carlos Gil <carlosgilglez@gmail.com>
@dpgeorge
extmod/mbedtls: Enable certificate time/date validation by default.
b5449b0 
All ports using this common configuration already enable time/date
validation, so this commit is a no-op change.

Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge
Copy link
Member

dpgeorge commented Dec 1, 2023

This looks fine. I also added a follow-up commit to move this date/time configuration to extmod/mbedtls/mbedtls_config_common.h.

@github-actions
Copy link

github-actions bot commented Dec 1, 2023

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:  +683 +0.085% standard[incl +8(data)]
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS

@dpgeorge dpgeorge merged commit b5449b0 into micropython:master Dec 1, 2023
@Carglglz Carglglz deleted the unix_mbedtls_time branch December 1, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

port-unix

Projects

None yet

Milestone

release-1.22.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Carglglz @dpgeorge