Skip to content

ISSUE-93: support stars in negation extglobs with expression after closing parenthesis#102

Merged
mrmlnc merged 1 commit intomasterfrom
ISSUE-93_incorrect_extglob_expanding
Jan 2, 2022
Merged

ISSUE-93: support stars in negation extglobs with expression after closing parenthesis#102
mrmlnc merged 1 commit intomasterfrom
ISSUE-93_incorrect_extglob_expanding

Conversation

@mrmlnc
Copy link
Contributor

@mrmlnc mrmlnc commented Jan 2, 2022

What is the purpose of this pull request?

This is a fix for #93.

What changes did you make? (Give an overview)

Please read the comment in the code. More context of the suggested solution is here.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 92.33% when pulling ac3cb66 on ISSUE-93_incorrect_extglob_expanding into 719d348 on master.

Copy link
Member

@jonschlinkert jonschlinkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great solution, LGTM! Nice work!

Feel free to merge and publish.

@mrmlnc mrmlnc merged commit 9f241ef into master Jan 2, 2022
@mrmlnc mrmlnc deleted the ISSUE-93_incorrect_extglob_expanding branch January 2, 2022 16:54
@damphu1986 damphu1986 mentioned this pull request Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants