fix: set negatedExtGlob also if it does not span the whole pattern

danez · danez · commit 032e3f51800a · 2021-04-10T11:22:08.000+02:00
This way micromatch can detect that this is a negation pattern.
diff --git a/lib/parse.js b/lib/parse.js
@@ -247,7 +247,7 @@ const parse = (input, options) => {
         output = token.close = `)$))${extglobStar}`;
       }
 
-      if (token.prev.type === 'bos' && eos()) {
+      if (token.prev.type === 'bos') {
         state.negatedExtglob = true;
       }
     }
diff --git a/test/api.picomatch.js b/test/api.picomatch.js
@@ -347,4 +347,19 @@ describe('picomatch', () => {
       });
     });
   });
+
+  describe('state', () => {
+    describe('negatedExtglob', () => {
+      it('should return true', () => {
+        assert(picomatch('!(abc)', {}, true).state.negatedExtglob);
+        assert(picomatch('!(abc)**', {}, true).state.negatedExtglob);
+        assert(picomatch('!(abc)/**', {}, true).state.negatedExtglob);
+      });
+
+      it('should return false', () => {
+        assert(!picomatch('(!(abc))', {}, true).state.negatedExtglob);
+        assert(!picomatch('**!(abc)', {}, true).state.negatedExtglob);
+      });
+    });
+  });
 });

Original file line number	Diff line number	Diff line change
`@@ -247,7 +247,7 @@ const parse = (input, options) => {`
`247`	`247`	output = token.close = `)$))${extglobStar}`;
`248`	`248`	`}`
`249`	`249`
`250`		`- if (token.prev.type === 'bos' && eos()) {`
	`250`	`+ if (token.prev.type === 'bos') {`
`251`	`251`	`state.negatedExtglob = true;`
`252`	`252`	`}`
`253`	`253`	`}`