Replace Syscall with x/sys/unix.IoctlSetWinsize#1
Replace Syscall with x/sys/unix.IoctlSetWinsize#1dmaluka merged 3 commits intomicro-editor:masterfrom
Syscall with x/sys/unix.IoctlSetWinsize#1Conversation
JoeKar
left a comment
There was a problem hiding this comment.
Looks good, in case it works.
Should we go to v0.31.0 now?
|
I tested the pull request on OpenIndiana (illumos distribution) last week but I was able to cross-compile and run Micro.
I could update it, but I do not know if dependency packages like |
Good point. |
JoeKar
left a comment
There was a problem hiding this comment.
@dmaluka:
Any complains?
When we pick this one up within micro, then it's the first step towards *BSD support again.
We then just need micro-editor/tcell#2 too.
|
LGTM. |
|
4be3967 has reminded me that we ought to do the same in micro... Uploaded micro-editor/micro#3704 |
There are platforms where
SYS_IOCTLis not defined probably because libc functions have to be used. Reasons whySyscallcannot be used in any platform may be added or changed but they would be handled inx/sys/unixand Go source code, so the call is replaced in this pull request.Small unrelated style changes were also done in other commits.
Edit: The code in the orgnanization repository only is changed, so the issues in the old fork are not closed with this pull request now.