Adding embedded Info.plist to OS X builds#513
Merged
zyedidia merged 1 commit intomicro-editor:masterfrom Dec 29, 2016
samdmarshall:master
Merged
Adding embedded Info.plist to OS X builds#513zyedidia merged 1 commit intomicro-editor:masterfrom samdmarshall:master
zyedidia merged 1 commit intomicro-editor:masterfrom
samdmarshall:master
Conversation
Member
|
I'm not very familiar with these |
Contributor
Author
|
Sure, in this case it enables a single stand-alone binary to act as a traditional |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a metadata file to the binary as part of the build for OS X. This gives the binary a way to be identified by the system (using an info.plist). I followed the pattern of using a golang file as part of the
tools/directory to generate that file and the appropriate flags that need to be provided to the go linker for this to be properly added.If you would prefer some of this be changed or re-organized in any way, i'd be happy to make any changes.