Fix unwanted view adjustment after page down#3555
Merged
JoeKar merged 1 commit intomicro-editor:masterfrom Dec 3, 2024
Merged
Conversation
Fix regression introduced while implementing nano-like page up/down in commit b2dbcb3: if the view is already at the end of the buffer and the last line is even above the bottom, i.e. there are some empty lines displayed below the last line (e.g. if we have scrolled past the last line via the mouse wheel), pressing PageDown not just moves the cursor to the last line but also unexpectedly adjusts the view so that the last line is exactly at the bottom.
Contributor
|
Oops, my bad. Quite an edge case. Looks good. |
JoeKar
approved these changes
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix regression introduced while implementing nano-like page up/down in #3518 (of which mostly I am guilty): if the view is already at the end of the buffer and the last line is even above the bottom, i.e. there are some empty lines displayed below the last line (e.g. if we have scrolled past the last line via the mouse wheel), pressing PageDown not just moves the cursor to the last line but also unexpectedly adjusts the view so that the last line is exactly at the bottom.
@nimishjha FYI.