Skip to content

Unicode: Fix wide runes in various scenarios#3516

Draft
JoeKar wants to merge 4 commits intomicro-editor:masterfrom
JoeKar:fix/wide-runes
Draft

Unicode: Fix wide runes in various scenarios#3516
JoeKar wants to merge 4 commits intomicro-editor:masterfrom
JoeKar:fix/wide-runes

Conversation

@JoeKar
Copy link
Member

@JoeKar JoeKar commented Oct 21, 2024

  • remove @ replacement char for incomplete wide runes
  • fix tabbar > marker with wide runes
  • fix tabbar tab activation with wide runes
  • fix infobar prompt with wide rune name -> fix drawing of wide characters in InfoWindow #3919
  • fix line flickering in bufwindow in case of selected wide rune string and window resize

Fixes #2277
Fixes #3514

@zDEFz
Copy link

zDEFz commented Oct 21, 2024

That's cool, it fixes the search issue. But it has some edge-case that isn't covered.
if you e.g paste 少女少女 少 女少女少女少 女少少女 into the window and then start resizing, you can still make the '@' appear. image

@JoeKar
Copy link
Member Author

JoeKar commented Oct 22, 2024 via email

@JoeKar JoeKar marked this pull request as draft October 22, 2024 16:07
@JoeKar JoeKar changed the title Unicode: Fix wide runes in info-/tabwindow and statusline Unicode: Fix wide runes in various szenarios Oct 22, 2024
@JoeKar
Copy link
Member Author

JoeKar commented Jan 30, 2025

@dmaluka:
Maybe it is better to process such long-runners within micro's upstream repository instead of our forks. Then we've the chance that every contributor with write access can directly support/proceed/take-over etc.pp.
What do you think?

@dmaluka
Copy link
Collaborator

dmaluka commented Jan 30, 2025

You mean, create a branch in this repo (https://github.com/zyedidia/micro)? If needed, we always can, but I'm not sure why are asking about it here. Speaking of this PR, I simply had no time to look into it yet, and also I saw it marked as "draft" so I didn't prioritize it.

@JoeKar
Copy link
Member Author

JoeKar commented Jan 31, 2025

You mean, create a branch in this repo (https://github.com/zyedidia/micro)?

Yes.

If needed, we always can, but I'm not sure why are asking about it here.

The contribution of different people in PRs from a different repositories isn't as easy as it is in the upstream one.
In other words:
If you have time and desire then you could contribute in such a branch too.

This was the idea behind this question.

Speaking of this PR, I simply had no time to look into it yet, and also I saw it marked as "draft" so I didn't prioritize it.

The intention of my question wasn't about a review (see above), so no hurry.

@JoeKar JoeKar changed the title Unicode: Fix wide runes in various szenarios Unicode: Fix wide runes in various scenarios Mar 8, 2025
@Andriamanitra Andriamanitra mentioned this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

shift_jis encoding display unsupported in Find, FindLiteral etc Chinese characters become at sign(@) in search bar

3 participants