add actions CursorToViewTop, CursorToViewCenter, CursorToViewBottom#3506
Conversation
b3b112d to
caaa595
Compare
0dda2d6 to
2ceac22
Compare
|
Please squash the commits into one, there is no point in having a broken commit immediately followed by a commit that fixes it. |
2ceac22 to
0a13b56
Compare
b755e9d to
a5754fd
Compare
a5754fd to
5e8e899
Compare
5e8e899 to
46b8725
Compare
46b8725 to
526cc19
Compare
526cc19 to
4be79fa
Compare
4be79fa to
8fe1708
Compare
JoeKar
left a comment
There was a problem hiding this comment.
Currently it's hard to identify the difference from the usual Page{Up|Down} to PageUp,CursorToViewTop resp. PageDown,CursorToViewBottom.
Do I something wrong?
Would be nice to have a CursorKeep for chaining to provide the possibility to align the behavior to many other editors.
Well,
Don't worry, that's coming up in the next PR. Instead of |
Well, yes...but more precise it changes the view to |
I think you mean |
Yes.
Are we still talking about Since I'm still puzzled about |
Yeah, I think I haven't been able to make myself clear so far. The purpose of You can certainly chain them with To recap: this PR is solely to implement the |
|
@JoeKar I also don't quite get your point. Also to remind just in case: ...If we change the behavior of |
Ok guys, excuse me. I was too stubborn and fixed/focus on this other "use case" (most probably it isn't even one in that combination) and totally ignored the stand-alone purpose. So let us bring this to an end here. |
This PR adds three new actions:
CursorToViewTopCursorToViewCenterCursorToViewBottomBoth the first and last actions apply an offset of
scrollmarginto avoid the view jumping when the user hits a cursor movement key.