Autocomplete unknown value in set filetype ...#3214
Merged
dmaluka merged 2 commits intomicro-editor:masterfrom Mar 25, 2024
Merged
Autocomplete unknown value in set filetype ...#3214dmaluka merged 2 commits intomicro-editor:masterfrom
unknown value in set filetype ...#3214dmaluka merged 2 commits intomicro-editor:masterfrom
Conversation
`unknown` is a valid value for the `filetype` option (and executing `set filetype unknown` does what is expected: it forces filetype autodetection). So let's add `unknown` to the autocomplete suggestions for `filetype`, along with actual filetypes.
Andriamanitra
approved these changes
Mar 25, 2024
Contributor
Andriamanitra
left a comment
There was a problem hiding this comment.
Good change, works as expected.
and executing set filetype unknown does what is expected: it forces filetype autodetection
That's definitely not what I thought it would do, but that's beside the point 😆
Collaborator
Author
|
Help says: So, it does not explicitly say that ...Hmm, the |
It is also a documented special value of the `filetype` option.
Collaborator
Author
JoeKar
reviewed
Mar 25, 2024
JoeKar
approved these changes
Mar 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unknownis a valid value for thefiletypeoption (and executingset filetype unknowndoes what is expected: it forces filetype autodetection). So let's addunknownto the autocomplete suggestions forfiletype, along with actual filetypes.