fix: zip.Insert not saving permissions#35
Merged
mholt merged 1 commit intomholt:mainfrom Jun 12, 2025
Merged
Conversation
Owner
|
Thanks! Sorry for my delay getting to this. Have you tested that this does work for you? |
Contributor
Author
yeah! it worked for me, but i've since switched to just using STARRY-S/zip directly |
Owner
|
Oh okay -- why's that? (I'll probably still merge this since it seems to solve a problem.) |
mholt
approved these changes
Jun 12, 2025
Contributor
Author
just to cut down on the dependencies needed. i was only working with zipfiles, and it was taking a while to get this pr merged, so i just decided to use it directly. thanks for merging, though! |
Owner
|
Gotcha, yeah that makes sense! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just a simple change to fix permission bits not being saved on files being inserted into a zipfile. i'm using archives on a project of mine and noticed that all files being inserted have 0644 permissions, despite the files having 0755 perms. after a bit of digging, i found that the Append method being used does not save file permissions due to creating its own FileHeader. according to the docs for AppendHeader:
hdris not being modified after calling AppendHeader, so this should really work just fine