Fix error closing files from Filesystem#18
Merged
mholt merged 2 commits intomholt:mainfrom Feb 17, 2025
Merged
Conversation
mholt
approved these changes
Feb 17, 2025
Owner
mholt
left a comment
There was a problem hiding this comment.
Ah, nice find. Thanks for the patch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17
The underlying issue for #17 was a typed nil bug. A nil
*os.Filewas being assigned tocloseBoth.cwhich is anio.Closer. So this non-nil check will always be true even when the original *os.File is nil.The solution in this PR is only make
fsFileacloseBothwhenarchiveFile != nil.