feat(DNA): Add customizable color props to DNA loader#189
Merged
mhnpd merged 2 commits intomhnpd:masterfrom Aug 31, 2025
Merged
feat(DNA): Add customizable color props to DNA loader#189mhnpd merged 2 commits intomhnpd:masterfrom
mhnpd merged 2 commits intomhnpd:masterfrom
Conversation
Owner
|
@Signor1 Please resolve the conflict. |
Contributor
Author
|
Alright @mhnpd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request resolves issue #156 by adding the ability to customize the colors of the
DNAloader component directly via props. Previously, the colors were hardcoded, forcing users to rely on CSS overrides.Changes
dnaColorOneanddnaColorTwoprops: TheDNAcomponent now accepts two optional string props to set the colors of the DNA strands.tinycolor2library. It dynamically generates the intermediate frame of the color animation, preserving the original aesthetic (one color brightens, the other fades).tinycolor2is now a dependency.How to Use
The new props make customization simple and declarative.
Before:
Now: