Skip to content

Build script environment cleanup#3

Merged
mhils merged 2 commits intomhils:masterfrom
TBBle:build-script-iteration
Feb 11, 2017
Merged

Build script environment cleanup#3
mhils merged 2 commits intomhils:masterfrom
TBBle:build-script-iteration

Conversation

@TBBle
Copy link
Copy Markdown
Contributor

@TBBle TBBle commented Feb 11, 2017

While iterating on the build.ps1 script, I noticed that it started locking up or building the wrong things (confusing architecture state) after a few runs.

Two issues I identified:

  • After running, the Visual Studio environment variables were never popped
  • The 'cd' stack (from Pscx's Set-LocationEx alias) grows unboundedly

This avoids building a very large stack during repeat invocations.
@mhils
Copy link
Copy Markdown
Owner

mhils commented Feb 11, 2017

Thanks! 😃

@mhils mhils merged commit 4e14b41 into mhils:master Feb 11, 2017
@TBBle TBBle deleted the build-script-iteration branch February 11, 2017 17:55
@TBBle TBBle mentioned this pull request Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants