Skip to content

feat: add rustls-tls, native-tls features to enable equivalent features in ureq and reqwest#111

Merged
mgrachev merged 1 commit intomgrachev:mainfrom
dyc3:fix-musl-build
Jun 27, 2023
Merged

feat: add rustls-tls, native-tls features to enable equivalent features in ureq and reqwest#111
mgrachev merged 1 commit intomgrachev:mainfrom
dyc3:fix-musl-build

Conversation

@dyc3
Copy link
Copy Markdown
Contributor

@dyc3 dyc3 commented Jun 24, 2023

fixes #110

✔ Checklist:

@dyc3 dyc3 force-pushed the fix-musl-build branch from 8f16bef to 4cb9b17 Compare June 26, 2023 12:12
@dyc3 dyc3 changed the title fix: build failing with feature reqwest on x86_64-unknown-linux-musl fix: build failing with feature reqwest in target_env = "musl" Jun 26, 2023
@dyc3 dyc3 requested a review from mgrachev June 26, 2023 12:15
@dyc3 dyc3 force-pushed the fix-musl-build branch from 4cb9b17 to d4169b4 Compare June 26, 2023 16:13
@mgrachev
Copy link
Copy Markdown
Owner

Also, please add information about new features in the README.

@mgrachev mgrachev changed the title fix: build failing with feature reqwest in target_env = "musl" feat: add rustls-tls and native-tls features to enable equivalent features in ureq and reqwest Jun 26, 2023
@dyc3 dyc3 force-pushed the fix-musl-build branch from d4169b4 to e6b9f50 Compare June 26, 2023 17:44
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (df0f931) 93.98% compared to head (d4169b4) 93.98%.

❗ Current head d4169b4 differs from pull request most recent head e6b9f50. Consider uploading reports for the commit e6b9f50 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   93.98%   93.98%           
=======================================
  Files          13       13           
  Lines         648      648           
=======================================
  Hits          609      609           
  Misses         39       39           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dyc3 dyc3 force-pushed the fix-musl-build branch from e6b9f50 to 16f3018 Compare June 26, 2023 17:47
@dyc3 dyc3 requested a review from mgrachev June 26, 2023 17:57
@dyc3 dyc3 force-pushed the fix-musl-build branch from 16f3018 to eb0bf79 Compare June 26, 2023 21:22
@dyc3 dyc3 changed the title feat: add rustls-tls and native-tls features to enable equivalent features in ureq and reqwest feat: add rustls-tls, native-tls features to enable equivalent features in ureq and reqwest Jun 26, 2023
@mgrachev mgrachev merged commit 10bf06f into mgrachev:main Jun 27, 2023
@mgrachev
Copy link
Copy Markdown
Owner

@dyc3 Thank you for your help 👍

@dyc3 dyc3 deleted the fix-musl-build branch June 27, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Does not build for target x86_64-unknown-linux-musl when using reqwest

3 participants