Add regexp matching for route to element transformers #1430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
As a side not, I couldn't get the tests to run on PhantomJS. I got this error: Seems that angular isn't loaded on the window object when restangular is loaded... |
9a68bcb to
2fb4db0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As one possible solution to #1289 (but also as a useful feature in itself), I added regexp matching for the route parameter in addElementTransformer.
If the route is given as a regexp
/route/to addElementTransformer, then the transformer function is stored in a separate transformers array along with its "matcher". When transforming elements, the regexp transformer array is first iterated to check which transformers match the current route and execute those. After that, it goes on as normal.