This repository was archived by the owner on May 5, 2026. It is now read-only.
Switch OpenVLA to PromptReplacement with dedicated chat template#27
Closed
mgehre-amd wants to merge 0 commit into
Closed
Switch OpenVLA to PromptReplacement with dedicated chat template#27mgehre-amd wants to merge 0 commit into
mgehre-amd wants to merge 0 commit into
Conversation
8f3105e to
a0f3634
Compare
Collaborator
|
Thank you for these suggestions! Going down the PromptReplacement path dramatically improved things. I have integrated your changes into my branch, and listed you as a co-author. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mkorhone, I played a bit with your PR today to understand why the changes in vllm/benchmarks are necessary. It looks like they aren't when we use PromptReplacement and make a proper template_openvla.jinja, which generates the prompt in the order we need.
It looks like this produces the right output, both via
and via
vllm-bench.py, and would remove any changes in non-openvla-specific files from your PR.Please check whether that makes sense. I'm also not 100% sure that I validated the right thing.
Switch OpenVLA from PromptInsertion to PromptReplacement so the chat completions API can correctly place image tokens. PromptInsertion required get_placeholder_str to return None, which prevented the chat API from knowing where to insert image placeholders.
PromptReplacement uses (token 32000) as the target token. The new template_openvla.jinja chat template:
Also reverts benchmark files to match target branch.