Fix broken error handling when opening Guide Manager.#569
Merged
miquelcampos merged 1 commit intomgear-dev:masterfrom Nov 7, 2025
Merged
Fix broken error handling when opening Guide Manager.#569miquelcampos merged 1 commit intomgear-dev:masterfrom
miquelcampos merged 1 commit intomgear-dev:masterfrom
Conversation
…t_list` `pm.displayError` is a wrapper of `om.MGlobal.displayError`, which only accepts `str` arg.
Contributor
Author
|
I don't believe the build error is related to the commit. |
Member
|
Hi @timothyliu3d |
Contributor
Author
|
Hi Miquel @miquelcampos I am referring to the "code quality" CI workflow that fails when the PR is made: Hope that clarifies things. Thanks! |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Please clearly state what you have changed and why you made these changes.
Errors in custom components when opening Guide Manager only show
TypeErrorinstead of the relevant error because the exception instance is passed topm.displayError, which only acceptsstrarg.Remove an extraneous call with the incorrect arg.
Testing Done
Please describe the tests that you ran to verify your changes.
Tested with:
Intentional error in custom component properly shows in output instead of unrelated TypeError.
Related Issue(s)
Please link the related issues.
N/A