Fixed missing "size" on Guide file builds#486
Merged
miquelcampos merged 1 commit intomasterfrom Apr 8, 2025
Merged
Conversation
Contributor
Author
|
Hey @miquelcampos, I have fixed the issue but it will have the effect that the size value gets update dynamically from guide file, instead of having that data serialized into the .gst file. I am not sure if that design is what you want, please feel free to change it :) |
Member
|
@SimonBenAnderson I will check it later, not sure about the solution right now :) |
Member
|
@SimonBenAnderson Merged! I think is a good solution. Also help me to find a couple of things to polish. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
When building a guide from a hierarchy after the components have been created there is a call to the
addOptionsValuesthat generate the "size" option key value pair. This key value pair does not get generated anywhere else in the codebase.So I added it to the
set_from_dictthat gets called from the build_from_file.Testing Done
Built some guides using there
.gstfiles and the error no longer persisted and it looks like the builds completed correctly.Related Issue(s)
#485