Remove Redundant pm.parent Call in createGhostCtl to Fix Error with mgear.pymaya#467
Merged
miquelcampos merged 1 commit intomgear-dev:masterfrom Mar 4, 2025
Merged
Conversation
Member
|
@yamahigashi thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR removes an unnecessary pm.parent(shape, newCtl, r=True, s=True) call in the createGhostCtl function. Previously, importing pymel.core as pm masked the issue because there was no error, but switching to import mgear.pymaya as pm causes an error on this redundant parent call. Since the second pm.parent is not needed, it has been removed for clarity and compatibility.
Testing Done
Confirmed that removing the redundant call does not affect the final hierarchy or shape assignment.
Related Issue(s)
Please link the related issues.