FIX: adding stateChanged connection to import skin checkbox in guide settings#440
Closed
matthewlee-dev wants to merge 3 commits intomgear-dev:masterfrom
Closed
Conversation
Member
|
@mattdeform Thanks for the PR I copied manually the snippet from your PR. The branch have some merge conflicts and it is easier to do it this way instead of merge it. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Import Skin option in guide settings was not connected to the guide settings attr on the guide transform node. This was leading to the checkbox state not being updated when the user clicked it in the guide settings UI.
Testing Done
Please describe the tests that you ran to verify your changes.
Related Issue(s)