Skip to content

support php#571

Merged
metrue merged 2 commits intomasterfrom
fix-php
Oct 13, 2020
Merged

support php#571
metrue merged 2 commits intomasterfrom
fix-php

Conversation

@metrue
Copy link
Owner

@metrue metrue commented Oct 13, 2020

Issue:
Summary:

The checklist before PR is ready for review:

  • has unit testing for new added codes
  • has functional testing for new added features
  • has checked the lint or style issues
  • README updated if need

@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 22.19%. Comparing base (9e7de8b) to head (5a3fcf8).
⚠️ Report is 27 commits behind head on master.

Files with missing lines Patch % Lines
bundle/bundle.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
- Coverage   24.71%   22.19%   -2.53%     
==========================================
  Files          54       55       +1     
  Lines        1942     1739     -203     
==========================================
- Hits          480      386      -94     
+ Misses       1381     1272     -109     
  Partials       81       81              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@metrue metrue merged commit 9582c06 into master Oct 13, 2020
@metrue metrue deleted the fix-php branch October 13, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant