Skip to content

Feature: add support for Crystal programming language#566

Merged
metrue merged 1 commit intometrue:masterfrom
mvrilo:feature/crystal-support
Aug 31, 2020
Merged

Feature: add support for Crystal programming language#566
metrue merged 1 commit intometrue:masterfrom
mvrilo:feature/crystal-support

Conversation

@mvrilo
Copy link
Contributor

@mvrilo mvrilo commented Aug 30, 2020

Issue:
Summary: add support for Crystal programming language

The checklist before PR is ready for review:

  • has unit testing for new added codes
  • has functional testing for new added features
  • has checked the lint or style issues
  • README updated if need

@codecov
Copy link

codecov bot commented Aug 30, 2020

Codecov Report

Merging #566 into master will decrease coverage by 0.43%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
- Coverage   24.48%   24.04%   -0.44%     
==========================================
  Files          53       54       +1     
  Lines        1932     1942      +10     
==========================================
- Hits          473      467       -6     
- Misses       1378     1399      +21     
+ Partials       81       76       -5     
Impacted Files Coverage Δ
bundle/bundle.go 76.92% <0.00%> (-6.42%) ⬇️
packer/rules.go 50.00% <ø> (ø)
utils/utils.go 12.34% <0.00%> (-0.08%) ⬇️
bundler/crystal/crystal.go 100.00% <100.00%> (ø)
container_runtimes/docker/sdk/docker.go 35.50% <0.00%> (-9.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bcc471...43e95e3. Read the comment docs.

Copy link
Owner

@metrue metrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very thoughtful PR, thanks @mvrilo, awesome works.

@metrue metrue merged commit b668d7c into metrue:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants