Skip to content

Fix the wrong arch of target host#524

Merged
metrue merged 2 commits intomasterfrom
fix-523
May 7, 2020
Merged

Fix the wrong arch of target host#524
metrue merged 2 commits intomasterfrom
fix-523

Conversation

@metrue
Copy link
Owner

@metrue metrue commented May 7, 2020

Issue: #523
Summary:

  • get the OS arch with uname -a
  • refactor the SSHConnectionTimeout constant

The checklist before PR is ready for review:

  • has unit testing for new added codes
  • has functional testing for new added features
  • has checked the lint or style issues
  • README updated if need

* get the OS arch with `uname -a`
* refactor the SSHConnectionTimeout constant
@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #524 into master will increase coverage by 0.07%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
+ Coverage   25.46%   25.54%   +0.07%     
==========================================
  Files          54       54              
  Lines        1873     1883      +10     
==========================================
+ Hits          477      481       +4     
- Misses       1317     1321       +4     
- Partials       79       81       +2     
Impacted Files Coverage Δ
middlewares/parse.go 33.64% <ø> (ø)
middlewares/driver.go 53.84% <38.88%> (-4.78%) ⬇️
provisioner/darwin/darwin.go 58.82% <100.00%> (ø)
provisioner/linux/linux.go 58.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3923c34...400c729. Read the comment docs.

@metrue metrue changed the title Fix the wrong arch of target host, Fix the wrong arch of target host May 7, 2020
@metrue metrue merged commit 5ce61ef into master May 7, 2020
@metrue metrue deleted the fix-523 branch May 7, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant