Merged
Conversation
metrue
approved these changes
Apr 28, 2020
Owner
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
==========================================
- Coverage 25.46% 24.77% -0.70%
==========================================
Files 54 54
Lines 1873 1873
==========================================
- Hits 477 464 -13
- Misses 1317 1335 +18
+ Partials 79 74 -5
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #517
Summary: replace full (debian-based) node image with lighter (alpine-based) node image
The checklist before PR is ready for review:
(*)
make lintcurrently fails for me on unrelated files