Skip to content

Provisioners#495

Merged
metrue merged 4 commits intomasterfrom
provisioners
Mar 19, 2020
Merged

Provisioners#495
metrue merged 4 commits intomasterfrom
provisioners

Conversation

@metrue
Copy link
Owner

@metrue metrue commented Mar 19, 2020

Issue:
Summary:

The checklist before PR is ready for review:

  • has unit testing for new added codes
  • has functional testing for new added features
  • has checked the lint or style issues
  • README updated if need

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #495 into master will increase coverage by 0.87%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #495      +/-   ##
==========================================
+ Coverage   24.59%   25.46%   +0.87%     
==========================================
  Files          53       54       +1     
  Lines        1850     1873      +23     
==========================================
+ Hits          455      477      +22     
+ Misses       1320     1317       -3     
- Partials       75       79       +4     
Impacted Files Coverage Δ
handlers/image.go 0.00% <0.00%> (ø)
middlewares/parse.go 33.64% <0.00%> (ø)
middlewares/driver.go 58.62% <40.00%> (-5.38%) ⬇️
provisioner/darwin/darwin.go 58.82% <58.82%> (ø)
provisioner/linux/linux.go 58.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99b3696...e7199dd. Read the comment docs.

@metrue metrue merged commit b569820 into master Mar 19, 2020
@metrue metrue deleted the provisioners branch March 19, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant