Skip to content

Bundler#473

Merged
metrue merged 2 commits intomasterfrom
bundler
Mar 10, 2020
Merged

Bundler#473
metrue merged 2 commits intomasterfrom
bundler

Conversation

@metrue
Copy link
Owner

@metrue metrue commented Mar 8, 2020

Issue: #465
Summary: Refactor bundler
The checklist before PR is ready for review:

  • has unit testing for new added codes
  • has functional testing for new added features
  • has checked the lint or style issues
  • README updated if need

@codecov
Copy link

codecov bot commented Mar 8, 2020

Codecov Report

Merging #473 into master will decrease coverage by 0.61%.
The diff coverage is 42.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #473      +/-   ##
==========================================
- Coverage   26.49%   25.88%   -0.62%     
==========================================
  Files          52       63      +11     
  Lines        2302     2357      +55     
==========================================
  Hits          610      610              
- Misses       1568     1635      +67     
+ Partials      124      112      -12
Impacted Files Coverage Δ
packer/packer.go 38.46% <ø> (-10.75%) ⬇️
packer/rules.go 50% <ø> (-9.38%) ⬇️
middlewares/language.go 0% <0%> (ø)
utils/dir.go 0% <0%> (ø)
middlewares/build.go 0% <0%> (ø) ⬆️
handlers/image.go 0% <0%> (ø) ⬆️
bundler/julia/julia.go 100% <100%> (ø)
bundler/java/java.go 100% <100%> (ø)
bundler/node/node.go 100% <100%> (ø)
bundler/python/python.go 100% <100%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2560dc2...6a95ea7. Read the comment docs.

@metrue metrue merged commit 871bb29 into master Mar 10, 2020
@metrue metrue deleted the bundler branch March 10, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant