Skip to content

When check a file is handler or not, should take extension account, otherewise it might be a directory, not a file#433

Merged
metrue merged 2 commits intomasterfrom
fix-packer
Dec 26, 2019
Merged

When check a file is handler or not, should take extension account, otherewise it might be a directory, not a file#433
metrue merged 2 commits intomasterfrom
fix-packer

Conversation

@metrue
Copy link
Owner

@metrue metrue commented Dec 26, 2019

Issue:
Summary:

The checklist before PR is ready for review:

  • has unit testing for new added codes
  • has functional testing for new added features
  • has checked the lint or style issues
  • README updated if need

otherewise it might be a directory, not a file
@codecov
Copy link

codecov bot commented Dec 26, 2019

Codecov Report

Merging #433 into master will decrease coverage by 0.03%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
- Coverage   33.87%   33.84%   -0.04%     
==========================================
  Files          49       49              
  Lines        2208     2210       +2     
==========================================
  Hits          748      748              
- Misses       1338     1339       +1     
- Partials      122      123       +1
Impacted Files Coverage Δ
packer/packer.go 49.57% <50%> (ø) ⬆️
packer/rules.go 59.37% <66.66%> (-3.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a968999...0047e66. Read the comment docs.

@metrue metrue merged commit aefb449 into master Dec 26, 2019
@metrue metrue deleted the fix-packer branch December 26, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant