Skip to content

add docker to dependency#422

Merged
metrue merged 3 commits intomasterfrom
add-docker-as-dependency
Dec 19, 2019
Merged

add docker to dependency#422
metrue merged 3 commits intomasterfrom
add-docker-as-dependency

Conversation

@metrue
Copy link
Owner

@metrue metrue commented Dec 19, 2019

Signed-off-by: Minghe Huang h.minghe@gmail.com

Issue:
Summary:

The checklist before PR is ready for review:

  • has unit testing for new added codes
  • has functional testing for new added features
  • has checked the lint or style issues
  • README updated if need

@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #422 into master will decrease coverage by 1.23%.
The diff coverage is 54.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
- Coverage   34.03%   32.79%   -1.24%     
==========================================
  Files          48       48              
  Lines        2192     2162      -30     
==========================================
- Hits          746      709      -37     
- Misses       1326     1331       +5     
- Partials      120      122       +2
Impacted Files Coverage Δ
utils/docker.go 46.15% <0%> (-8.4%) ⬇️
middlewares/provision.go 0% <0%> (ø) ⬆️
middlewares/build.go 0% <0%> (ø) ⬆️
packer/rules.go 63.33% <63.33%> (ø)
packer/packer.go 49.57% <81.81%> (-3.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc8374d...80d6e38. Read the comment docs.

@metrue metrue merged commit e132435 into master Dec 19, 2019
@metrue metrue deleted the add-docker-as-dependency branch December 19, 2019 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant