Merged
Conversation
|
Closing this PR due to no activity. Feel free to reopen. |
Member
Author
|
@TheRealNate I am going to merge this now, I used this branch in our project quite some time and it works without issues. Should this be published as new major version? There are no real "breaking" changes but the update itself is quite big. What do you think? |
This was referenced Feb 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates dependencies and replaces underscore (which is often cause of many vulnerabilities) with native implementations.
It also updates the CI and adds our own improved minimongo.
Note, that the minimongo-cache is currently only added as package from Github (see package.json) and I will replace this with the published package, once it's published.
Therefore, this PR first requires the minimongo PR to be reviewed/merged and the new minimongo package to be published.
How can I test this PR in my setup?
First uninstall
@meteorrn/corevianpm uninstall --save @meteorrn/corethen install this exact branch from GitHub:$ meteor npm install --save --save-exact "git+ssh://git@github.com/meteorrn/meteor-react-native/#update-dependencies"note the doublequotes here