Skip to content

fix: strictly respect autoConnect flag#153

Merged
jankapunkt merged 2 commits intomasterfrom
fix/autoConnnect
Apr 17, 2024
Merged

fix: strictly respect autoConnect flag#153
jankapunkt merged 2 commits intomasterfrom
fix/autoConnnect

Conversation

@jankapunkt
Copy link
Copy Markdown
Member

@jankapunkt jankapunkt commented Feb 14, 2024 •
edited
Loading

Summary

Fixes the issue where autoConnect: false did not 100% prevent auto-connect

Linked issue(s)

#150

Involved parts of the project

Meteor, DDP

Added tests?

Yes

Targeted Meteor release version

2.x

Reproduction

const endpoint = `ws://localhost:3000/websocket`;
Meteor.connect(endpoint, {
  AsyncStorage,
  NetInfo: null,
  autoConnect: false,
});
Meteor.getData().ddp.on('connected', () => console.debug('should never fire'))

@jankapunkt
Copy link
Copy Markdown
Member Author

jankapunkt commented Feb 14, 2024

@bratelefant I accidentally merged the other so this is a new PR, however I think this is even better, since the release will include this as an own bullet point in it's changelog later on

@jankapunkt
Copy link
Copy Markdown
Member Author

jankapunkt commented Feb 14, 2024 •
edited
Loading

Published @meteorrn/core@2.8.1-rc.1 for testing (also bumped companion versions)

@jankapunkt jankapunkt linked an issue Feb 14, 2024 that may be closed by this pull request
autoConnect is broken #150
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 16, 2024

Closing this PR due to no activity. Feel free to reopen.

@jankapunkt jankapunkt merged commit 768b9d0 into master Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bratelefant bratelefant Awaiting requested review from bratelefant

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

autoConnect is broken

1 participant

@jankapunkt