fix: enableVerbose() not setting isVerbose correctly#140
Merged
jankapunkt merged 4 commits intometeorrn:devfrom Dec 22, 2023
Merged
fix: enableVerbose() not setting isVerbose correctly#140jankapunkt merged 4 commits intometeorrn:devfrom
jankapunkt merged 4 commits intometeorrn:devfrom
Conversation
Member
|
Thank you for pointing this out! If I get it correct then you aim to make the This is not your fault, but due to bad design (using a local variable and a property at the same time to determine if is verbose). In order to make really all verbosity statements work I propose the following changes:
Would you mind updating your pull request accordingly? |
Contributor
Author
|
I don't think it is needed to mark |
jankapunkt
approved these changes
Dec 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix broken
Meteor.enableVerbose()due to settingisVerbosein wrong scope.Involved parts of the project
pretty much all parts :)
Targeted Meteor release version
doesn't affect communication with Meteor
Reproduction
Currently
Meteor.enableVerbose()doesn't log extra info.With this fix
Meteor.enableVerbose()brings back allconsole.warnlogs