Merged
Conversation
Merge release 2.5.0 into master
jankapunkt
requested changes
Jul 3, 2023
Member
jankapunkt
left a comment
There was a problem hiding this comment.
Please run npm run lint in order to fix the lint error. Apart from that it looks good to me
not-ai-yet
approved these changes
Jul 3, 2023
Collaborator
|
Tentatively approved, but @jankapunkt's changes should be done first |
jankapunkt
reviewed
Jul 4, 2023
Member
jankapunkt
left a comment
There was a problem hiding this comment.
Code looks good, I will run the network scan today to see if I can confirm the behavior, too. If confirmed I will approve / merge.
jankapunkt
approved these changes
Jul 4, 2023
Member
|
I will get a new release 2.5.1 out asap |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on iOS and android, on iOS I also checked via a proxy if, when using
reachabilityUrloption, googles servers are no longer contacted.