Skip to content

Replaced wolfy87-eventemitter with core EventEmtiter from 'events'#116

Merged
not-ai-yet merged 3 commits intomasterfrom
deps-remove-wolfy87-eventemitter
Jun 8, 2023
Merged

Replaced wolfy87-eventemitter with core EventEmtiter from 'events'#116
not-ai-yet merged 3 commits intomasterfrom
deps-remove-wolfy87-eventemitter

Conversation

@jankapunkt
Copy link
Copy Markdown
Member

implementes #112

@jankapunkt jankapunkt linked an issue Jun 6, 2023 that may be closed by this pull request
not-ai-yet
not-ai-yet previously approved these changes Jun 7, 2023
Copy link
Copy Markdown
Collaborator

@not-ai-yet not-ai-yet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

@not-ai-yet
Copy link
Copy Markdown
Collaborator

@jankapunkt can you resolve merge conflicts, GitHub keeps giving me issues

@jankapunkt
Copy link
Copy Markdown
Member Author

@TheRealNate yes I will look at them

@jankapunkt jankapunkt requested a review from not-ai-yet June 8, 2023 06:20
@jankapunkt
Copy link
Copy Markdown
Member Author

@TheRealNate resolved

@not-ai-yet not-ai-yet merged commit 2f9b4fb into master Jun 8, 2023
@jankapunkt
Copy link
Copy Markdown
Member Author

Thanks @TheRealNate I will create a new release 2.5.0 and publish on NPM.

@juanpmd
Copy link
Copy Markdown

juanpmd commented Aug 22, 2023

@jankapunkt does this change require installing the npm package events? I am having problems running meteorrn without it but wanted to make sure this is the correct way.

@jankapunkt
Copy link
Copy Markdown
Member Author

Hey @juanpmd I investigated and it seems to be a mistake from my end here. The tests never catched this, since they run with node, which itself holds events but the React Native engine doesn't know about events and it's not possible to simply install them. The npm events package is also not an official core package and not maintained since two years. I'm thinking if finding a good solution here, maybe eventemitter3?

@jankapunkt
Copy link
Copy Markdown
Member Author

@juanpmd can you please take a look at PR #129 and let me know if this works for your setup without the need for the events dependency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make wolfy87-eventemitter an optional dependency

4 participants