Closed
Conversation
radekmie
reviewed
Nov 28, 2022
Comment on lines
+8
to
+12
| "@babel/runtime": "^7.17.9", | ||
| "@testing-library/react": "^13.4.0", | ||
| "meteor-node-stubs": "^1.2.1", | ||
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0" |
Collaborator
There was a problem hiding this comment.
It'd be safer to pin these.
Contributor
Author
I kept them because I cannot migrate other tests due to the npm dependencies issue. I will remove them later. |
1 task
Member
|
Hey, thanks for working on this PR. Right now, there's no way to run tests on React packages. I created a new PR basing on this one and updating to latest 3.x. Closing in favor of #422 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is created as a draft because there is an issue with testing package with NPM dependencies. I created the harness app to run for now only
react-meteor-datapackage tests.Previously,
api.mainModule('tests.js');was used to add tests. However, this error occurs when it is run this way with the new Meteor version:It can be fixed by using
Npm.depends, but it cannot be made only for tests.If the client and server code will be stored in different files, then adding tests as I made here
api.addFiles(['useFind.ts', 'useFind.tests.js'], 'client');will be available. However, we will need to rewrite those packages completely.Is there any way to split client and server code because the previous approach doesn't work? Now running a test on the server will throw that error.